java - Is there a more elegant way of doing this? (Cannot be more descriptive.) -

-

i have 3 non-static classes representing musical composition. these score, part , note class.

score contains instance variable arraylist<part> representing multiple instrument parts of score, , part contains instance variable arraylist<note> representing note sequence.

public class score {     private arraylist<part> parts;    private int resolution;     public score(int resolution) {       parts = new arraylist<part>();       this.resolution = resolution;    }     public void addpart(part part) {       parts.add(part);    }     public arraylist<part> getparts() {       return parts;    }     public int getresolution() {       return resolution;    } }  public class part {     private arraylist<note> notes;     public part() {       notes = new arraylist<note>();    }     public void addnote(note note) {       notes.add(note);    }     public arraylist<note> getnotes() {       return notes;    } }  public class note() {    private long startstamp;    private long endstamp;    private int resolution;     public note(long startstamp, long endstamp, int resolution) {       this.startstamp = startstamp;       this.endstamp = endstamp;       resolution = resolution;    }     public double getduration() {       int duration = (double) (getendstamp() - getstartstamp()) / resolution;       return duration;    } }

duration of each note calculated using score resolution. resolution of particular score instance passed through note construtor each time note instantiated. note added arraylist<note> notes of corresponding part instance, , part added arraylist<part> parts of score instance.

my solution of using int resolution note constructor parameter doesn't seem elegant, since there many notes belonging same score, i.e. resolution attribute of score rather attribute of note.

is there way resolution referencing corresponding score object inside note class, instead of passing resolution through constructor of note class, or perhaps other solution?

it seems resolution pertains score (based on design), not note - why not change method signature of note#getduration calculate duration @ specific resolution:

public double getduration(int resolution) {   double duration = (double) (getendstamp() - getstartstamp()) / resolution;   return duration;

}

the same note can added different scores, different resolutions.

or better, why don't return:

public long getduration() {   return getendstamp() - getstartstamp();

}

and let calling code deal whatever conversion needs do?


Comments

Post a Comment

Popular posts from this blog

c# - SVN Error : "svnadmin: E205000: Too many arguments" -

-
i trying reposotries using c# code process svncommand = null; var psi = new processstartinfo("svnadmin"); psi.redirectstandardoutput = true; psi.redirectstandarderror = true; psi.useshellexecute = false; psi.arguments= @"dump c:\repositories\myrepo > c:\temp\myrepodumpfile.dump"; using (svncommand = process.start(psi)) { var myoutput = svncommand.standardoutput; var myerror = svncommand.standarderror; debug.write("output :" + environment.newline + environment.newline + myoutput.readtoend() + environment.newline + "error :" + environment.newline + environment.newline + myerror.readtoend()); svncommand.close(); } when use dump command commandline svnadmin dump c:\repositories\myrepo > c:\temp\myrepodumpfile.dump it works fine when try ...
Read more

c# - Copy ObservableCollection to another ObservableCollection -

-
how copy observablecollection item observablecollection without reference of first collection? here observablecollection item value changes affecting both collections. code private observablecollection<ratemodel> _allmetalrate = new observablecollection<ratemodel>(); private observablecollection<ratemodel> _metalrateondate = new observablecollection<ratemodel>(); public observablecollection<ratemodel> allmetalrate { { return this._allmetalrate; } set { this._allmetalrate = value; notifypropertychanged("metalrate"); } } public observablecollection<ratemodel> metalrateondate { { return this._metalrateondate; } set { this._metalrateondate = value; notifypropertychanged("metalrateondate"); } } foreach (var item in metalrateondate) allmetalrate.add(item); what causing , how can solve it? you need clone object referenced item before it's a...
Read more

All overlapping substrings matching a java regex -

-
is there api method returns (possibly overlapping) substrings match regular expression? for example, have text string: string t = 04/31 412-555-1235; , , have pattern: pattern p = new pattern("\\d\\d+"); matches strings of 2 or more characters. the matches are: 04, 31, 412, 555, 1235. how overlapping matches? i want code return: 04, 31, 41, 412, 12, 55, 555, 55, 12, 123, 1235, 23, 235, 35. theoretically should possible -- there obvious o(n^2) algorithm enumerates , checks substrings against pattern. edit rather enumerating substrings, safer use region(int start, int end) method in matcher . checking pattern against separate, extracted substring might change result of match (e.g. if there non-capturing group or word boundary check @ start/end of pattern). edit 2 actually, it's unclear whether region() expect zero-width matches. specification vague, , experiments yield disappointing results. for example: string line = "xx90xx"; strin...
Read more